]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: Use bool for @check_active parameter
authorJohn Ferlan <jferlan@redhat.com>
Mon, 18 Dec 2017 12:47:30 +0000 (07:47 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 4 Jan 2018 15:54:08 +0000 (10:54 -0500)
Use a bool as that's how the variable is used in the function.

src/conf/virstorageobj.c
src/conf/virstorageobj.h
src/storage/storage_driver.c

index 19903b6c5149641c57334738627f75702ee80957..1eaa53423d1e3b134ba0a52cad3b633df5d70a54 100644 (file)
@@ -1133,7 +1133,7 @@ virStoragePoolObjGetNames(virStoragePoolObjListPtr pools,
 int
 virStoragePoolObjIsDuplicate(virStoragePoolObjListPtr pools,
                              virStoragePoolDefPtr def,
-                             unsigned int check_active)
+                             bool check_active)
 {
     int ret = -1;
     virStoragePoolObjPtr obj = NULL;
index 4f372386afa6a5aa3145b3a24d99e1624c1773d2..dd7001c4b2d98d292835bc4f3cd8f17df5344a7b 100644 (file)
@@ -247,7 +247,7 @@ virStoragePoolObjRemove(virStoragePoolObjListPtr pools,
 int
 virStoragePoolObjIsDuplicate(virStoragePoolObjListPtr pools,
                              virStoragePoolDefPtr def,
-                             unsigned int check_active);
+                             bool check_active);
 
 int
 virStoragePoolObjSourceFindDuplicate(virConnectPtr conn,
index f86087fb0f64076e95b13b9c9c3c6db5184ab2be..f590f6b9be30257b872027c74fbe360850f59347 100644 (file)
@@ -656,7 +656,7 @@ storagePoolCreateXML(virConnectPtr conn,
     if (virStoragePoolCreateXMLEnsureACL(conn, newDef) < 0)
         goto cleanup;
 
-    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, 1) < 0)
+    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, true) < 0)
         goto cleanup;
 
     if (virStoragePoolObjSourceFindDuplicate(conn, driver->pools, newDef) < 0)
@@ -751,7 +751,7 @@ storagePoolDefineXML(virConnectPtr conn,
     if (virStoragePoolDefineXMLEnsureACL(conn, newDef) < 0)
         goto cleanup;
 
-    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, 0) < 0)
+    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, false) < 0)
         goto cleanup;
 
     if (virStoragePoolObjSourceFindDuplicate(conn, driver->pools, newDef) < 0)