]> xenbits.xensource.com Git - libvirt.git/commitdiff
event-test: Use switch instead of if/else if chains for lifecycle event translation
authorPeter Krempa <pkrempa@redhat.com>
Thu, 14 Apr 2016 12:44:07 +0000 (14:44 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 18 Apr 2016 14:31:28 +0000 (16:31 +0200)
examples/object-events/event-test.c

index 9a53bb156b9090b03947cd89690bbf7762745ee4..b265e2e11f2a459bebc87916e3d7cf710b68fed2 100644 (file)
@@ -91,20 +91,30 @@ eventDetailToString(int event,
     const char *ret = "";
     switch ((virDomainEventType) event) {
         case VIR_DOMAIN_EVENT_DEFINED:
-            if (detail == VIR_DOMAIN_EVENT_DEFINED_ADDED)
+            switch ((virDomainEventDefinedDetailType) detail) {
+            case VIR_DOMAIN_EVENT_DEFINED_ADDED:
                 ret = "Added";
-            else if (detail == VIR_DOMAIN_EVENT_DEFINED_UPDATED)
+                break;
+            case VIR_DOMAIN_EVENT_DEFINED_UPDATED:
                 ret = "Updated";
-            else if (detail == VIR_DOMAIN_EVENT_DEFINED_RENAMED)
+                break;
+            case VIR_DOMAIN_EVENT_DEFINED_RENAMED:
                 ret = "Renamed";
-            else if (detail == VIR_DOMAIN_EVENT_DEFINED_FROM_SNAPSHOT)
+                break;
+            case  VIR_DOMAIN_EVENT_DEFINED_FROM_SNAPSHOT:
                 ret = "Snapshot";
+                break;
+            }
             break;
         case VIR_DOMAIN_EVENT_UNDEFINED:
-            if (detail == VIR_DOMAIN_EVENT_UNDEFINED_REMOVED)
+            switch ((virDomainEventUndefinedDetailType) detail) {
+            case VIR_DOMAIN_EVENT_UNDEFINED_REMOVED:
                 ret = "Removed";
-            else if (detail == VIR_DOMAIN_EVENT_UNDEFINED_RENAMED)
+                break;
+            case VIR_DOMAIN_EVENT_UNDEFINED_RENAMED:
                 ret = "Renamed";
+                break;
+            }
             break;
         case VIR_DOMAIN_EVENT_STARTED:
             switch ((virDomainEventStartedDetailType) detail) {