]> xenbits.xensource.com Git - xen.git/commitdiff
xen: arm: correctly write release target in smp_spin_table_cpu_up
authorIan Campbell <ian.campbell@citrix.com>
Tue, 14 Jan 2014 16:55:04 +0000 (16:55 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Thu, 13 Mar 2014 10:59:11 +0000 (10:59 +0000)
flush_xen_data_tlb_range_va() is clearly bogus since it flushes the tlb, not
the data cache. Perhaps what was meant was flush_xen_dcache(), but the address
was mapped with ioremap_nocache and hence isn't cached in the first place.
Accesses should be via writeq though, so do that.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
xen/arch/arm/arm64/smpboot.c

index 1287c72a650bb94e2e4ad6b6506242d7753895c7..91464769d1f8747e6bafe348a1789c509338fb6b 100644 (file)
@@ -32,8 +32,7 @@ static int __init smp_spin_table_cpu_up(int cpu)
         return -EFAULT;
     }
 
-    release[0] = __pa(init_secondary);
-    flush_xen_data_tlb_range_va((vaddr_t)release, sizeof(*release));
+    writeq(__pa(init_secondary), release);
 
     iounmap(release);