]> xenbits.xensource.com Git - xen.git/commitdiff
complete conversion set_bit() -> __cpumask_set_cpu() by 4aaca0e9cd
authorJan Beulich <jbeulich@suse.com>
Fri, 27 Feb 2015 15:09:27 +0000 (16:09 +0100)
committerJan Beulich <jbeulich@suse.com>
Fri, 27 Feb 2015 15:09:27 +0000 (16:09 +0100)
While converting to __cpumask_set_cpu() was correct, the first argument
passed should have been corrected to be "cpu" instead of "nr" at once.
The wrong construct results in problems on systems with relatively few
CPUs.

Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citirx.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
xen/common/softirq.c

index bb79aacf7845a6b17a28006ce61bd1bf0516d5d3..11e3345397e0ee9e7cc585fc35eef8acf358ebd8 100644 (file)
@@ -106,7 +106,7 @@ void cpu_raise_softirq(unsigned int cpu, unsigned int nr)
     if ( !per_cpu(batching, this_cpu) || in_irq() )
         smp_send_event_check_cpu(cpu);
     else
-        __cpumask_set_cpu(nr, &per_cpu(batch_mask, this_cpu));
+        __cpumask_set_cpu(cpu, &per_cpu(batch_mask, this_cpu));
 }
 
 void cpu_raise_softirq_batch_begin(void)