]> xenbits.xensource.com Git - xen.git/commitdiff
xen/arm: gic-v3: Make sure read from ICC_IAR1_EL1 is visible on the redistributor
authorJulien Grall <julien.grall@arm.com>
Wed, 18 Jan 2017 18:54:08 +0000 (18:54 +0000)
committerStefano Stabellini <sstabellini@kernel.org>
Wed, 18 Jan 2017 21:36:32 +0000 (13:36 -0800)
"The effects of reading ICC_IAR0_EL1 and ICC_IAR1_EL1 on the state of a
returned INTID are not guaranteed to be visible until after the execution
of a DSB".

Because of the GIC is an external component, a dsb sy is required.
Without it the sysreg read may not have been made visible on the
redistributor.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
xen/arch/arm/gic-v3.c

index 9910877d40a8cea8d023379557124d1bca6cce49..a811a24f2dcdbde385eac39935cd9819e1c09e1f 100644 (file)
@@ -459,7 +459,11 @@ static void gicv3_dir_irq(struct irq_desc *irqd)
 
 static unsigned int gicv3_read_irq(void)
 {
-    return READ_SYSREG32(ICC_IAR1_EL1);
+    unsigned int irq = READ_SYSREG32(ICC_IAR1_EL1);
+
+    dsb(sy);
+
+    return irq;
 }
 
 static inline uint64_t gicv3_mpidr_to_affinity(int cpu)