]> xenbits.xensource.com Git - people/aperard/qemu-dm.git/commitdiff
migration: Minor control flow simplification
authorEric Blake <eblake@redhat.com>
Thu, 20 Apr 2023 14:35:51 +0000 (09:35 -0500)
committerJuan Quintela <quintela@redhat.com>
Mon, 24 Apr 2023 13:01:46 +0000 (15:01 +0200)
No need to declare a temporary variable.

Suggested-by: Juan Quintela <quintela@redhat.com>
Fixes: 1df36e8c6289 ("migration: Handle block device inactivation failures better")
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c

index d91fe9fd8622c968600c0c4475066012f3bfe026..9ec6c1e204c35d6261b1e559043e119c13c22742 100644 (file)
@@ -3431,7 +3431,6 @@ static void migration_completion(MigrationState *s)
         ret = global_state_store();
 
         if (!ret) {
-            bool inactivate = !migrate_colo_enabled();
             ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
             trace_migration_completion_vm_stop(ret);
             if (ret >= 0) {
@@ -3439,10 +3438,10 @@ static void migration_completion(MigrationState *s)
                                             MIGRATION_STATUS_DEVICE);
             }
             if (ret >= 0) {
-                s->block_inactive = inactivate;
+                s->block_inactive = !migrate_colo_enabled();
                 qemu_file_set_rate_limit(s->to_dst_file, INT64_MAX);
                 ret = qemu_savevm_state_complete_precopy(s->to_dst_file, false,
-                                                         inactivate);
+                                                         s->block_inactive);
             }
         }
         qemu_mutex_unlock_iothread();