]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER
authorPeter Krempa <pkrempa@redhat.com>
Wed, 16 Feb 2022 15:24:01 +0000 (16:24 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 17 Feb 2022 12:15:46 +0000 (13:15 +0100)
The fix was on RPC level so everything should advertise it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/driver.c

index d070861cfdf788f0de118d3d9ccd6071f3d231e6..bcf5db599868170a3fc0867d9c115494a4b3019d 100644 (file)
@@ -357,10 +357,14 @@ virDriverFeatureIsGlobal(virDrvFeature feat,
      * At this point everything supports them and thus also drivers need to
      * always advertise this feature */
     case VIR_DRV_FEATURE_TYPED_PARAM_STRING:
+    /* Feature flag exposes that the accidental switching of order of arguments
+     * in the public API trampoline virNetworkUpdate is known. Updated clients
+     * thus use the correct ordering with an updated server. All drivers must
+     * signal support for this feature. */
+    case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER:
         *supported = 1;
         return true;
 
-    case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER:
     case VIR_DRV_FEATURE_FD_PASSING:
     case VIR_DRV_FEATURE_MIGRATION_V2:
     case VIR_DRV_FEATURE_MIGRATION_V3: