]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
contrib/plugins: fix coverity warning in hotblocks
authorAlex Bennée <alex.bennee@linaro.org>
Mon, 9 Oct 2023 16:41:04 +0000 (17:41 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Wed, 11 Oct 2023 07:46:39 +0000 (08:46 +0100)
Coverity complains that we have an unbalance use of mutex leading to
potential deadlocks.

Fixes: CID 1519048
Fixes: a208ba09bd ("tests/plugin: add a hotblocks plugin")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231009164104.369749-26-alex.bennee@linaro.org>

contrib/plugins/hotblocks.c

index 6b74d25fead613529df5300db665c8b38ad26d96..4de1b134944770320ca4c64deb87f4bf6ab32181 100644 (file)
@@ -69,8 +69,8 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
         }
 
         g_list_free(it);
-        g_mutex_unlock(&lock);
     }
+    g_mutex_unlock(&lock);
 
     qemu_plugin_outs(report->str);
 }