]> xenbits.xensource.com Git - people/andrewcoop/xen.git/commitdiff
x86/io_apic: address violation of MISRA C:2012 Rule 10.1
authorNicola Vetrini <nicola.vetrini@bugseng.com>
Fri, 27 Oct 2023 13:34:12 +0000 (15:34 +0200)
committerStefano Stabellini <stefano.stabellini@amd.com>
Sat, 18 Nov 2023 02:03:52 +0000 (18:03 -0800)
The definition of IO_APIC_BASE contains a sum of an essentially enum
value (FIX_IO_APIC_BASE_0) that is positive with an index that, in all
instances, is unsigned, therefore the former is cast to unsigned, so that
the operands are of the same essential type.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/include/asm/io_apic.h

index a7e4c9e146de51a3d90ae5a18f9c10a8e702fb23..206bb961c0051e84ca170155200debcc0298247a 100644 (file)
  * Copyright (C) 1997, 1998, 1999, 2000 Ingo Molnar
  */
 
-#define IO_APIC_BASE(idx)                                               \
-    ((volatile uint32_t *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + (idx))    \
-                           + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK)))
+#define IO_APIC_BASE(idx)                                         \
+    ((volatile uint32_t *)                                        \
+     (__fix_to_virt((unsigned int)FIX_IO_APIC_BASE_0 + (idx)) +   \
+                    (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK)))
 
 #define IO_APIC_ID(idx) (mp_ioapics[idx].mpc_apicid)