]> xenbits.xensource.com Git - people/liuw/xen.git/commitdiff
x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6
authorCorneliu ZUZU <czuzu@bitdefender.com>
Thu, 18 Feb 2016 14:08:25 +0000 (15:08 +0100)
committerWei Liu <wei.liu2@citrix.com>
Tue, 15 Mar 2016 16:32:28 +0000 (16:32 +0000)
c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to common-side",
introduced a use without initialization issue.
hvm_event_breakpoint calls hvm_event_traps(&req) and if sync is true that
ors some bits into req->flags which was never initialised.
Reported by Coverity Scan.

Initializes req @ hvm_event_breakpoint entry.

Coverity-ID: 1353192
Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/hvm/event.c

index 874a36c119e78852123f6f240bde9230608fc764..cb9c15205586125d41ce111b5fd2d8815e4d45ba 100644 (file)
@@ -173,7 +173,7 @@ int hvm_event_breakpoint(unsigned long rip,
 {
     struct vcpu *curr = current;
     struct arch_domain *ad = &curr->domain->arch;
-    vm_event_request_t req;
+    vm_event_request_t req = {};
 
     switch ( type )
     {