]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: xml: Enforce return value check from virXMLFormatElement
authorPeter Krempa <pkrempa@redhat.com>
Fri, 22 Feb 2019 16:36:23 +0000 (17:36 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 6 Mar 2019 14:53:51 +0000 (15:53 +0100)
The function does not transfer errors from 'attrBuf' and 'childBuf'
arguments into 'buf', but rather reports them right away, thus we need
to make sure that it's always checked.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/virxml.h

index 78a1e7fa5ef71736b17de85ab683d24c15eaca5b..b91fedde82a5f9d0a6a75ed339787de0628767a0 100644 (file)
@@ -217,7 +217,8 @@ int
 virXMLFormatElement(virBufferPtr buf,
                     const char *name,
                     virBufferPtr attrBuf,
-                    virBufferPtr childBuf);
+                    virBufferPtr childBuf)
+    ATTRIBUTE_RETURN_CHECK;
 
 struct _virXPathContextNodeSave {
     xmlXPathContextPtr ctxt;