]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
build: Rename `_import_linker` to `import_linker`
authorSimon Kuenzer <simon@unikraft.io>
Fri, 8 Sep 2023 23:32:07 +0000 (01:32 +0200)
committerRazvan Deaconescu <razvand@unikraft.io>
Fri, 20 Oct 2023 16:35:55 +0000 (19:35 +0300)
This commit renames the Makefile function `_import_linker` to `import_linker`.
The original intent was for this function to be purely internal and only
used in the core `Makefile`. It turns out that it might be used in other
places in the future, like potentilly external architectures, so this
commit removes the inappropriate `_` prefix.

Signed-off-by: Simon Kuenzer <simon@unikraft.io>
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Reviewed-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1104

Makefile
support/build/Makefile.rules

index 1f5245a08a86d3405e73c015f285842b40a71e2b..3fc9dad91c9ccb2ae767b34295e4ff5d2f7214da 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -768,7 +768,7 @@ $(foreach _D,$(UK_DEPS) $(UK_DEPS-y),\
 endif
 
 # include Makefile for platform linking (`Linker.uk`)
-$(foreach plat,$(UK_PLATS),$(eval $(call _import_linker,$(plat))))
+$(foreach plat,$(UK_PLATS),$(eval $(call import_linker,$(plat))))
 
 .PHONY: prepare preprocess image libs objs clean
 
index a3b18e64651b0f2fb3996f55a8803321403af8c4..1ef4799403d86d76cd9b87a34e1d30e8d9ea1a0e 100644 (file)
@@ -246,8 +246,8 @@ IMPORT_BASE := $(1)
 $(call verbose_include,$(1)/Makefile.uk)
 undefine IMPORT_BASE
 endef
-# _import_linker $plat_name
-define _import_linker =
+# import_linker $plat_name
+define import_linker =
 $(call verbose_include,$(UK_PLAT_$(call uc,$(1))_LINKER))
 endef