]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
vpci/msix: reduce indentation in msix_write PBA handling
authorRoger Pau Monné <roger.pau@citrix.com>
Tue, 1 Mar 2022 09:02:13 +0000 (10:02 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 1 Mar 2022 09:02:13 +0000 (10:02 +0100)
No functional change.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/drivers/vpci/msix.c

index 2ab4079412f25686d8a5e0ed804a23cf8a4743b5..a1fa7a5f13f1c3652e3cd8491d2a71e8e2586897 100644 (file)
@@ -275,23 +275,24 @@ static int cf_check msix_write(
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
-        /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
-        if ( is_hardware_domain(d) )
+
+        if ( !is_hardware_domain(d) )
+            /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
+            return X86EMUL_OKAY;
+
+        switch ( len )
         {
-            switch ( len )
-            {
-            case 4:
-                writel(data, addr);
-                break;
+        case 4:
+            writel(data, addr);
+            break;
 
-            case 8:
-                writeq(data, addr);
-                break;
+        case 8:
+            writeq(data, addr);
+            break;
 
-            default:
-                ASSERT_UNREACHABLE();
-                break;
-            }
+        default:
+            ASSERT_UNREACHABLE();
+            break;
         }
 
         return X86EMUL_OKAY;