virNetDevBandwidthUnplug: Don't leak @cmd

When removing a TAP device, the associated bandwidth settings are
removed. Currently, the /sbin/tc is used for that. It is spawned
several times. Moreover, we use the same @cmd variable to
construct the command and its arguments. That means we need to
virCommandFree(cmd); prior to each virCommandNew(TC); which
wasn't done.

diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c
index ccc1449d7695253845e1f138ffebf0500a448eca..74e6c8cbc07c7fc5c80a69593d5b5125282f0a88 100644 (file)
--- a/src/util/virnetdevbandwidth.c
+++ b/src/util/virnetdevbandwidth.c
@@ -519,6 +519,7 @@ virNetDevBandwidthUnplug(const char *brname,
     if (virCommandRun(cmd, &cmd_ret) < 0)
         goto cleanup;
 
+    virCommandFree(cmd);
     cmd = virCommandNew(TC);
     virCommandAddArgList(cmd, "class", "del", "dev", brname,
                          "classid", class_id, NULL);