tools: ipxe: Correct download error handling

This shell fragment lacked set -e.  So, eg if the download failed a
broken ipxe.tar.gz would be left behind.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Tested-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>

diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index 3868f876ea3bba62b07b3477d06937df5fa37790..fd8dfdf5a78421f7cfe9da8c12f71e744a5e9686 100644 (file)
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -33,7 +33,7 @@ $(ROM): $(ROMS)
        $(MAKE) -C $D/src bin/$(*F).rom
 
 $T:
-       if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
+       set -e; if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
                $(GIT) clone $(IPXE_GIT_URL) $D.git; \
                (cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
                $(IPXE_GIT_TAG) | gzip -n >../_$T); \