]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: domain: Initialize proper element in qemuDomainPrepareStorageSourceBlockdev
authorPeter Krempa <pkrempa@redhat.com>
Tue, 9 Oct 2018 08:55:00 +0000 (10:55 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 5 Dec 2018 16:53:26 +0000 (17:53 +0100)
We are preparing a certain disk source passed in as '@src' so the
individual functions should use that rather than disk->src which
corresponds to the top level element of the chain only.

Without this change TLS and persistent reservations would not work for
backing images of a chain when using -blockdev.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_domain.c

index 9ed7115dab197128ca38f595a4af407452a7e4f5..509da6bfeaf71df93b1b38b425d00b8eefe5d014 100644 (file)
@@ -13462,10 +13462,10 @@ qemuDomainPrepareStorageSourceBlockdev(virDomainDiskDefPtr disk,
                                              src->nodeformat) < 0)
         return -1;
 
-    if (qemuDomainPrepareStorageSourcePR(disk->src, priv, src->nodestorage) < 0)
+    if (qemuDomainPrepareStorageSourcePR(src, priv, src->nodestorage) < 0)
         return -1;
 
-    if (qemuDomainPrepareStorageSourceTLS(disk->src, cfg, src->nodestorage,
+    if (qemuDomainPrepareStorageSourceTLS(src, cfg, src->nodestorage,
                                           priv->qemuCaps) < 0)
         return -1;