]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
ionic: return -EFAULT if copy_to_user() fails
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Apr 2021 10:47:59 +0000 (13:47 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Apr 2021 22:08:18 +0000 (15:08 -0700)
The copy_to_user() function returns the number of bytes that it wasn't
able to copy.  We want to return -EFAULT to the user.

Fixes: fee6efce565d ("ionic: add hw timestamp support files")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_phc.c

index 177dbf89affdbed75d3b27a89ecea2cfe30264f3..a87c87e86aef6499a23ea37b37598d711491db30 100644 (file)
@@ -225,7 +225,9 @@ int ionic_lif_hwstamp_get(struct ionic_lif *lif, struct ifreq *ifr)
        memcpy(&config, &lif->phc->ts_config, sizeof(config));
        mutex_unlock(&lif->phc->config_lock);
 
-       return copy_to_user(ifr->ifr_data, &config, sizeof(config));
+       if (copy_to_user(ifr->ifr_data, &config, sizeof(config)))
+               return -EFAULT;
+       return 0;
 }
 
 static u64 ionic_hwstamp_read(struct ionic *ionic,