]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
tests/unit/test-util-sockets: Use g_file_open_tmp() to create temp file
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Fri, 24 Dec 2021 23:45:04 +0000 (00:45 +0100)
committerThomas Huth <thuth@redhat.com>
Wed, 5 Jan 2022 10:10:13 +0000 (11:10 +0100)
Similarly to commit e63ed64c6d1 ("tests/qtest/virtio-net-failover:
Use g_file_open_tmp() to create temporary file"), avoid calling
g_test_rand_int() before g_test_init(): use g_file_open_tmp().

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20211224234504.3413370-1-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/unit/test-util-sockets.c

index 72b92465298218927da6ab240d1173e2e984cef5..896247e3ed36323159df0fcdcf6529324d070503 100644 (file)
@@ -305,9 +305,11 @@ static void test_socket_unix_abstract(void)
     };
     int i;
 
+    i = g_file_open_tmp("unix-XXXXXX", &addr.u.q_unix.path, NULL);
+    g_assert_true(i >= 0);
+    close(i);
+
     addr.type = SOCKET_ADDRESS_TYPE_UNIX;
-    addr.u.q_unix.path = g_strdup_printf("unix-%d-%u",
-                                         getpid(), g_random_int());
     addr.u.q_unix.has_abstract = true;
     addr.u.q_unix.abstract = true;
     addr.u.q_unix.has_tight = false;