]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: hook: use VIR_AUTOPTR for aggregate types
authorSukrit Bhatnagar <skrtbhtngr@gmail.com>
Tue, 24 Jul 2018 15:52:19 +0000 (21:22 +0530)
committerErik Skultety <eskultet@redhat.com>
Fri, 27 Jul 2018 15:21:11 +0000 (17:21 +0200)
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/util/virhook.c

index 4673655dee22e470d812a1ac8e5d512d53b1f359..993f06d819616d0cd9b9fa979675712c7717f97f 100644 (file)
@@ -232,7 +232,7 @@ virHookCall(int driver,
 {
     int ret;
     VIR_AUTOFREE(char *) path = NULL;
-    virCommandPtr cmd;
+    VIR_AUTOPTR(virCommand) cmd = NULL;
     const char *drvstr;
     const char *opstr;
     const char *subopstr;
@@ -314,7 +314,5 @@ virHookCall(int driver,
                        virGetLastErrorMessage());
     }
 
-    virCommandFree(cmd);
-
     return ret;
 }