]> xenbits.xensource.com Git - people/iwj/osstest.git/commitdiff
proxy config: Actually set https_proxy too
authorIan Jackson <ian.jackson@eu.citrix.com>
Tue, 25 Apr 2017 13:15:40 +0000 (13:15 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 25 Apr 2017 15:12:34 +0000 (16:12 +0100)
05406e5aaffb "proxy config: Set https_proxy too" was ineffective
because in d22b80bb "proxy config: Factor out http_proxy_envsettings"
the variable name $var was not substituted into the new
supposedly-more-general shell rune, which consequently lacked the
appropriate generality.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Osstest/TestSupport.pm

index d482e1de946a17570f704cd5e88ca622322753d6..19bdd23177992d2c210d7b228fdcbd45f30906b6 100644 (file)
@@ -1911,7 +1911,7 @@ sub http_proxy_envsettings ($) {
     return unless $proxy;
     my @script;
     foreach my $var (qw(http_proxy https_proxy)) {
-        push @script, "http_proxy=$proxy", "export http_proxy";
+        push @script, "$var=$proxy", "export $var";
     }
     return (join '; ', @script).';';
 }