]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: Avoid NULL dereference in qemuSharedDiskEntryFree
authorJiri Denemark <jdenemar@redhat.com>
Tue, 12 Mar 2013 08:10:41 +0000 (09:10 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 12 Mar 2013 08:10:41 +0000 (09:10 +0100)
At least one caller may call qemuSharedDiskEntryFree with NULL as the
first argument. Let's make the function similar to other *Free functions
and do nothing in such case.

src/qemu/qemu_conf.c

index 3ef3499bbd9fb210a7d7b0f505f7d069b9fabced..24086105f71f769e9e3a2e3146d7b35c8012ce00 100644 (file)
@@ -1045,6 +1045,9 @@ qemuSharedDiskEntryFree(void *payload, const void *name ATTRIBUTE_UNUSED)
     qemuSharedDiskEntryPtr entry = payload;
     size_t i;
 
+    if (!entry)
+        return;
+
     for (i = 0; i < entry->ref; i++) {
         VIR_FREE(entry->domains[i]);
     }