]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
oxenstored: track commit history
authorJonathan Davies <jonathan.davies@citrix.com>
Mon, 27 Mar 2017 08:58:29 +0000 (08:58 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 28 Mar 2017 12:07:04 +0000 (13:07 +0100)
Since the list of historic activity cannot grow without bound, it is safe to use
this to track commits.

Signed-off-by: Jonathan Davies <jonathan.davies@citrix.com>
Reviewed-by: Thomas Sanders <thomas.sanders@citrix.com>
tools/ocaml/xenstored/process.ml

index 20e31ae59fbfbdafb777303200199c0a691b6fb0..9a68bbb856b04ae2caf48db42418ed37b4d2bb4d 100644 (file)
@@ -281,12 +281,7 @@ let write_response_log ~ty ~tid ~con ~response =
 let record_commit ~con ~tid ~before ~after =
        let inc r = r := Int64.add 1L !r in
        let finish_count = inc Transaction.counter; !Transaction.counter in
-       (* This call would leak memory if historic activity is retained forever
-          so can only be uncommented if history is guaranteed not to grow
-          unboundedly.
        History.push {History.con=con; tid=tid; before=before; after=after; finish_count=finish_count}
-       *)
-       ()
 
 (* Replay a stored transaction against a fresh store, check the responses are
    all equivalent: if so, commit the transaction. Otherwise send the abort to