]> xenbits.xensource.com Git - xen.git/commitdiff
x86: Fix pirq teardown on domain destruction.
authorWei Gang <gang.wei@intel.com>
Wed, 26 Jan 2011 08:54:12 +0000 (08:54 +0000)
committerWei Gang <gang.wei@intel.com>
Wed, 26 Jan 2011 08:54:12 +0000 (08:54 +0000)
The privilege check in unmap_domain_pirq() fails since the teardown
completes in RCU (idle domain) context. We can remove the check since
it is covered in physdev_op() already, which is the only potentially
unprivileged caller.

Signed-off-by: Wei Gang <gang.wei@intel.com>
xen/arch/x86/irq.c

index 11bd233794687fd033ca3a2eb0d83c786d2f2b34..3275b2d07c39175fa044dd241fba7eddab8baf2d 100644 (file)
@@ -1567,9 +1567,6 @@ int unmap_domain_pirq(struct domain *d, int pirq)
     if ( (pirq < 0) || (pirq >= d->nr_pirqs) )
         return -EINVAL;
 
-    if ( !IS_PRIV_FOR(current->domain, d) )
-        return -EINVAL;
-
     ASSERT(spin_is_locked(&pcidevs_lock));
     ASSERT(spin_is_locked(&d->event_lock));