]> xenbits.xensource.com Git - people/dariof/libvirt.git/commitdiff
configure: make --with-test-suite work
authorMartin Kletzander <mkletzan@redhat.com>
Wed, 18 Dec 2013 06:59:19 +0000 (07:59 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 18 Dec 2013 13:13:25 +0000 (14:13 +0100)
Our option '--with-test-suite' could have never worked since it was
defined as AC_ARG_ENABLE([with-test-suite], ...), thus working only as
'--enable-with-test-suite', but documented in configure.ac as
AC_HELP_STRING([--with-test-suite], ...).
In my opinion, the help string is as it should be, but the option is
wrong.

The option has been broken since the introduction in commit 3a2fc27.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
configure.ac

index 54466343a43d78167faa454ee3ac093b56e56d70..2ebb9412ca662979442c436959b4f2c72f168ec5 100644 (file)
@@ -2035,14 +2035,14 @@ dnl Allow perl/python overrides
 AC_PATH_PROGS([PYTHON], [python2 python])
 AC_PATH_PROG([PERL], [perl])
 
-AC_ARG_ENABLE([with-test-suite],
-              [AS_HELP_STRING([--with-test-suite],
-                 [build test suite by default @<:@default=check@:>@])],
-              [case "${withval}" in
-                 yes|no|check) ;;
-                 *)      AC_MSG_ERROR([bad value ${withval} for tests option]) ;;
-              esac],
-              [withval=check])
+AC_ARG_WITH([test-suite],
+            [AS_HELP_STRING([--with-test-suite],
+               [build test suite by default @<:@default=check@:>@])],
+            [case "${withval}" in
+               yes|no|check) ;;
+               *)      AC_MSG_ERROR([bad value ${withval} for tests option]) ;;
+            esac],
+            [withval=check])
 
 AC_MSG_CHECKING([Whether to build test suite by default])
 if test "$withval" = "check" ; then