]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
hw/block/nvme: fix set feature for error recovery
authorGollu Appalanaidu <anaidu.gollu@samsung.com>
Sun, 24 Jan 2021 15:54:40 +0000 (21:24 +0530)
committerKlaus Jensen <k.jensen@samsung.com>
Mon, 8 Feb 2021 20:15:54 +0000 (21:15 +0100)
Only enable DULBE if the namespace supports it.

Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
hw/block/nvme.c

index 40784bd908fba8aa5ee004c37624513eb0a03557..b3d072c8b2bb7ddf9ae61b019ca431416f0aa5c8 100644 (file)
@@ -3396,7 +3396,9 @@ static uint16_t nvme_set_feature(NvmeCtrl *n, NvmeRequest *req)
         }
 
         assert(ns);
-        ns->features.err_rec = dw11;
+        if (NVME_ID_NS_NSFEAT_DULBE(ns->id_ns.nsfeat))  {
+            ns->features.err_rec = dw11;
+        }
         break;
     case NVME_VOLATILE_WRITE_CACHE:
         for (i = 1; i <= n->num_namespaces; i++) {