build: warn on a large frame by default

My commit e73889b6311f5b43d859caa4bae84bfdb299967a
split the -Wframe-larger-than warning setting into
two different variables - STRICT_FRAME_LIMIT_CFLAGS
for the library code and RELAXED_FRAME_LIMIT_CFLAGS
which was needed for tests.

Use the strict limit by default and specify the warning
flag twice for the parts that require a larger stack
frame, relying on the fact that the compiler will pick
up the latter value.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index be5dc3de514fc866ff85f51cab90f724023e1d35..5f930756b02d91d0a6b79d69a7fb11efcb995b08 100644 (file)
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -171,7 +171,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
     # This should be < 256 really. Currently we're down to 4096,
     # but using 1024 bytes sized buffers (mostly for virStrerror)
     # stops us from going down further
-    gl_WARN_ADD([-Wframe-larger-than=4096], [STRICT_FRAME_LIMIT_CFLAGS])
+    wantwarn="$wantwarn -Wframe-larger-than=4096"
     gl_WARN_ADD([-Wframe-larger-than=32768], [RELAXED_FRAME_LIMIT_CFLAGS])
 
     # Extra special flags

diff --git a/src/Makefile.am b/src/Makefile.am
index 013976a2b7f5c094d5a9edd5f56a836ba7d5bdc5..cd01796d6701c1d8c8a9d7881810cb788c971a75 100644 (file)
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -31,8 +31,6 @@ AM_CPPFLAGS = -I../gnulib/lib \
                -Dabs_top_srcdir="\"$(abs_top_srcdir)\"" \
                $(NULL)
 
-WARN_CFLAGS += $(STRICT_FRAME_LIMIT_CFLAGS)
-
 AM_CFLAGS =    $(LIBXML_CFLAGS) \
                $(GLIB_CFLAGS) \
                $(WARN_CFLAGS) \

diff --git a/tools/Makefile.am b/tools/Makefile.am
index 67b342d3060dc51f749c0db4c6f42a345ce3e248..426a6ba6610a1455c2de3ef724a2d6a311ad4ee0 100644 (file)
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -29,8 +29,6 @@ AM_CPPFLAGS = \
 # needed
 STANDALONE_CPPFLAGS = -I$(top_srcdir)
 
-WARN_CFLAGS += $(STRICT_FRAME_LIMIT_CFLAGS)
-
 AM_CFLAGS = \
        $(WARN_CFLAGS) \
        $(COVERAGE_CFLAGS) \