]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
Fix the qemu crash when guest shutdown in COLO mode
authorRao, Lei <lei.rao@intel.com>
Fri, 16 Oct 2020 05:52:02 +0000 (13:52 +0800)
committerJason Wang <jasowang@redhat.com>
Wed, 11 Nov 2020 08:52:23 +0000 (16:52 +0800)
In COLO mode, if the startup parameters of QEMU include "no-shutdown",
QEMU will crash when the guest shutdown. The root cause is when the
guest shutdown, the state of VM will switch COLO to SHUTDOWN. When do
checkpoint again, the state will be changed to COLO. But the state
switch is undefined in runstate_transitions_def, we should add it.
This patch fixes the following:
qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'colo'
Aborted

Signed-off-by: Lei Rao <lei.rao@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
softmmu/vl.c

index a71164494e60a1a39da128f265ba5fb49f322362..e32fd48f14bbaf1a20ffa39bbe74da14c11841b4 100644 (file)
@@ -632,6 +632,7 @@ static const RunStateTransition runstate_transitions_def[] = {
     { RUN_STATE_SHUTDOWN, RUN_STATE_PAUSED },
     { RUN_STATE_SHUTDOWN, RUN_STATE_FINISH_MIGRATE },
     { RUN_STATE_SHUTDOWN, RUN_STATE_PRELAUNCH },
+    { RUN_STATE_SHUTDOWN, RUN_STATE_COLO },
 
     { RUN_STATE_DEBUG, RUN_STATE_SUSPENDED },
     { RUN_STATE_RUNNING, RUN_STATE_SUSPENDED },