]> xenbits.xensource.com Git - people/dariof/libvirt.git/commitdiff
qemu: Don't miss errors when changing graphics passwords
authorMartin Kletzander <mkletzan@redhat.com>
Mon, 1 Jul 2013 07:23:04 +0000 (09:23 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 3 Jul 2013 12:56:13 +0000 (14:56 +0200)
Commit 23e8b5d8e7a92bac85b7fd2aca8992501bf680ee forgot to check the
return value for all calls to qemuDomainChangeGraphicsPasswords().

src/qemu/qemu_process.c

index 4fe343c02c0f863685c55c9ea10f6f3a1317511c..df0ac722a8b9a3d89aeb569a57a9478b0efaa71a 100644 (file)
@@ -2055,10 +2055,10 @@ qemuProcessInitPasswords(virConnectPtr conn,
                                                     &graphics->data.spice.auth,
                                                     cfg->spicePassword);
         }
-    }
 
-    if (ret < 0)
-        goto cleanup;
+        if (ret < 0)
+            goto cleanup;
+    }
 
     if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) {
         for (i = 0; i < vm->def->ndisks; i++) {