]> xenbits.xensource.com Git - unikraft/libs/lwip.git/commitdiff
Remove redundant argument from POSIX_SOCKET_FAMILY_REGISTER macro RELEASE-0.10.0
authorMaria Sfiraiala <maria.sfiraiala@gmail.com>
Sun, 21 Aug 2022 13:54:02 +0000 (16:54 +0300)
committerUnikraft <monkey@unikraft.io>
Mon, 22 Aug 2022 08:58:45 +0000 (08:58 +0000)
In the `POSIX_SOCKET_FAMILY_REGISTER` macro, when the IPv6 option is
selected, the third argument produces a compilation error.

Due to the macro being defined in
`unikraft/lib/posix-socket/include/uk/socket_driver.h` with only 2
arguments, the third argument becomes redundant.

This commit removes it and ensures that the `AF_INET6` is successfully
registered.

Signed-off-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Approved-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Pull-Request: #18

sockets.c

index 7a26eb6470b60b1f9d14d88cbb392110ad094ac2..5c3ffdc52727b876c26405d8246ff68a06c04bda 100644 (file)
--- a/sockets.c
+++ b/sockets.c
@@ -617,7 +617,7 @@ static struct posix_socket_ops lwip_posix_socket_ops = {
 POSIX_SOCKET_FAMILY_REGISTER(AF_INET, &lwip_posix_socket_ops);
 
 #ifdef CONFIG_LWIP_IPV6
-POSIX_SOCKET_FAMILY_REGISTER(AF_INET6, &lwip_posix_socket_ops, NULL);
+POSIX_SOCKET_FAMILY_REGISTER(AF_INET6, &lwip_posix_socket_ops);
 #endif /* CONFIG_LWIP_IPV6 */
 
 #include <lwip/if_api.h>