]> xenbits.xensource.com Git - libvirt.git/commitdiff
net: add debug logs
authorOleg Vasilev <oleg.vasilev@virtuozzo.com>
Tue, 4 Jul 2023 07:10:21 +0000 (13:10 +0600)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 24 Jul 2023 12:32:02 +0000 (14:32 +0200)
Helped to debug next patch use-after-free.

Signed-off-by: Oleg Vasilev <oleg.vasilev@virtuozzo.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/remote/remote_daemon_stream.c
src/rpc/virnetmessage.c

index 3b7519d2cb27960dc4eaadc388dbdbff47679822..38a2b6cceb3c8fb757dd9258b3d43164e9ff5325 100644 (file)
@@ -318,8 +318,8 @@ daemonStreamFilter(virNetServerClient *client,
         msg->header.serial != stream->serial)
         goto cleanup;
 
-    VIR_DEBUG("Incoming client=%p, rx=%p, serial=%u, proc=%d, status=%d",
-              client, stream->rx, msg->header.proc,
+    VIR_DEBUG("Incoming client=%p, rx=%p, msg=%p, serial=%u, proc=%d, status=%d",
+              client, stream->rx, msg, msg->header.proc,
               msg->header.serial, msg->header.status);
 
     virNetMessageQueuePush(&stream->rx, msg);
index 50cc335fd6b3534d9c20c87e805e11ef98cca5fd..af0f9cb30b5533402139193bc37b5c3398f5e443 100644 (file)
@@ -103,6 +103,8 @@ void virNetMessageQueuePush(virNetMessage **queue, virNetMessage *msg)
 {
     virNetMessage *tmp = *queue;
 
+    VIR_DEBUG("queue=%p msg=%p", queue, msg);
+
     if (tmp) {
         while (tmp->next)
             tmp = tmp->next;
@@ -117,10 +119,13 @@ virNetMessage *virNetMessageQueueServe(virNetMessage **queue)
 {
     virNetMessage *tmp = *queue;
 
+    VIR_DEBUG("queue serve start queue=%p *queue=%p", queue, *queue);
+
     if (tmp) {
         *queue = g_steal_pointer(&tmp->next);
     }
 
+    VIR_DEBUG("queue serve end queue=%p *queue=%p", queue, *queue);
     return tmp;
 }