]> xenbits.xensource.com Git - libvirt.git/commitdiff
virSecurityManagerNewStack: Don't ignore virSecurityStackAddNested retval
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 21 Aug 2018 12:54:52 +0000 (14:54 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 5 Sep 2018 08:58:13 +0000 (10:58 +0200)
The virSecurityStackAddNested() can fail in which case
virSecurityManagerNewStack() should fail too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/security/security_manager.c

index e1b571ea52b1e1d42fcb79b810c29d51a0a743cd..21eb6f7452a75ac43c2f77076ca0ca82e5998ec8 100644 (file)
@@ -117,9 +117,13 @@ virSecurityManagerNewStack(virSecurityManagerPtr primary)
     if (!mgr)
         return NULL;
 
-    virSecurityStackAddNested(mgr, primary);
+    if (virSecurityStackAddNested(mgr, primary) < 0)
+        goto error;
 
     return mgr;
+ error:
+    virObjectUnref(mgr);
+    return NULL;
 }