]> xenbits.xensource.com Git - arm/linux.git/commitdiff
s390/disassembler: add missing end marker for e7 table
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Tue, 26 Sep 2017 07:16:48 +0000 (09:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:39:00 +0000 (08:39 +0000)
commit 5c50538752af7968f53924b22dede8ed4ce4cb3b upstream.

The e7 opcode table does not have an end marker. Hence when trying to
find an unknown e7 instruction the code will access memory behind the
table until it finds something that matches the opcode, or the kernel
crashes, whatever comes first.

This affects not only the in-kernel disassembler but also uprobes and
kprobes which refuse to set a probe on unknown instructions, and
therefore search the opcode tables to figure out if instructions are
known or not.

Fixes: 3585cb0280654 ("s390/disassembler: add vector instructions")
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/s390/kernel/dis.c

index c74c59236f4418c3f37933ff67b4812c101e8536..de925c575cfe690d76056e1d9cb9fa23f2bb6dee 100644 (file)
@@ -1548,6 +1548,7 @@ static struct s390_insn opcode_e7[] = {
        { "vfsq", 0xce, INSTR_VRR_VV000MM },
        { "vfs", 0xe2, INSTR_VRR_VVV00MM },
        { "vftci", 0x4a, INSTR_VRI_VVIMM },
+       { "", 0, INSTR_INVALID }
 };
 
 static struct s390_insn opcode_eb[] = {