]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commitdiff
spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu()
authorAndreas Färber <afaerber@suse.de>
Fri, 15 Feb 2013 15:43:08 +0000 (16:43 +0100)
committerAndreas Färber <afaerber@suse.de>
Sat, 16 Feb 2013 13:51:00 +0000 (14:51 +0100)
The helper functions all access ppc-specific fields only so don't bother
to change arguments to PowerPCCPU and use env_ptr instead.

No functional change.

Acked-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Andreas Färber <afaerber@suse.de>
hw/spapr_hcall.c

index af1db6ea0855fe0fd911fec6c5190cfb98359f2a..7b8959488e79c124e932d4eceff3ed9b44dcb943 100644 (file)
@@ -469,16 +469,11 @@ static target_ulong h_register_vpa(PowerPCCPU *cpu, sPAPREnvironment *spapr,
     CPUPPCState *tenv;
     CPUState *tcpu;
 
-    for (tenv = first_cpu; tenv; tenv = tenv->next_cpu) {
-        tcpu = CPU(ppc_env_get_cpu(tenv));
-        if (tcpu->cpu_index == procno) {
-            break;
-        }
-    }
-
-    if (!tenv) {
+    tcpu = qemu_get_cpu(procno);
+    if (!tcpu) {
         return H_PARAMETER;
     }
+    tenv = tcpu->env_ptr;
 
     switch (flags) {
     case FLAGS_REGISTER_VPA: