tests: Fix mode_t usage with va_arg()

Clang complains about it:

  error: second argument to 'va_arg' is of promotable type
  'mode_t' (aka 'unsigned short'); this va_arg has undefined
  behavior because arguments will be promoted to 'int'
  [-Werror,-Wvarargs]

    mode = va_arg(ap, mode_t);
                      ^~~~~~

Work around the issue by passing int to va_arg() and casting
its return value to mode_t afterwards.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

diff --git a/tests/nssmock.c b/tests/nssmock.c
index 7929c3061c942935059e7e96c88e62d143204348..fc8e6b22f01b989001aacfc41d4d395f8c114ed5 100644 (file)
--- a/tests/nssmock.c
+++ b/tests/nssmock.c
@@ -87,7 +87,7 @@ open(const char *path, int flags, ...)
         va_list ap;
         mode_t mode;
         va_start(ap, flags);
-        mode = va_arg(ap, int);
+        mode = (mode_t) va_arg(ap, int);
         va_end(ap);
         ret = real_open(newpath ? newpath : path, flags, mode);
     } else {

diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c
index 56337c2f3e090db0d2fe02ef8e07c98c841a729d..51861be38ee7a09c3b3910dca9f5cf6c17d4c9a8 100644 (file)
--- a/tests/vircgroupmock.c
+++ b/tests/vircgroupmock.c
@@ -731,7 +731,7 @@ int open(const char *path, int flags, ...)
         va_list ap;
         mode_t mode;
         va_start(ap, flags);
-        mode = va_arg(ap, mode_t);
+        mode = (mode_t) va_arg(ap, int);
         va_end(ap);
         ret = real_open(newpath ? newpath : path, flags, mode);
     } else {

diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index 79352175deb933a69b95b6ad1476ed2183417303..7e4ac191d038e8d3f20452236edcd27f4aade063 100644 (file)
--- a/tests/virpcimock.c
+++ b/tests/virpcimock.c
@@ -983,7 +983,7 @@ open(const char *path, int flags, ...)
         va_list ap;
         mode_t mode;
         va_start(ap, flags);
-        mode = va_arg(ap, mode_t);
+        mode = (mode_t) va_arg(ap, int);
         va_end(ap);
         ret = real_open(newpath ? newpath : path, flags, mode);
     } else {

diff --git a/tests/virtestmock.c b/tests/virtestmock.c
index 255dd4356070e6a44b428fb226d81020604d60a2..9b91adec7759ec5374ecd1f0333d1493862e716a 100644 (file)
--- a/tests/virtestmock.c
+++ b/tests/virtestmock.c
@@ -180,7 +180,7 @@ int open(const char *path, int flags, ...)
         va_list ap;
         mode_t mode;
         va_start(ap, flags);
-        mode = va_arg(ap, mode_t);
+        mode = (mode_t) va_arg(ap, int);
         va_end(ap);
         ret = real_open(path, flags, mode);
     } else {