]> xenbits.xensource.com Git - libvirt.git/commitdiff
daemon: sasl: Don't forget to save SASL username to client's identity
authorErik Skultety <eskultet@redhat.com>
Thu, 28 Jul 2016 14:42:04 +0000 (16:42 +0200)
committerErik Skultety <eskultet@redhat.com>
Tue, 2 Aug 2016 06:25:42 +0000 (08:25 +0200)
Once the SASL authentication process has successfully passed, we should also
save the SASL username used to client's identity, so that when a client like
virt-admin tries to obtain it, the server will actually format the username to
the response data.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
daemon/remote.c

index 4aa43c22395e1ccc7f8d70d2d118d1496876adc5..6991a7e67df01deef6f7b4c28ff9939c79baf16e 100644 (file)
@@ -3116,6 +3116,7 @@ static int
 remoteSASLFinish(virNetServerPtr server,
                  virNetServerClientPtr client)
 {
+    virIdentityPtr clnt_identity = NULL;
     const char *identity;
     struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
     int ssf;
@@ -3138,9 +3139,13 @@ remoteSASLFinish(virNetServerPtr server,
     if (!virNetSASLContextCheckIdentity(saslCtxt, identity))
         return -2;
 
+    if (!(clnt_identity = virNetServerClientGetIdentity(client)))
+        goto error;
+
     virNetServerClientSetAuth(client, 0);
     virNetServerTrackCompletedAuth(server);
     virNetServerClientSetSASLSession(client, priv->sasl);
+    virIdentitySetSASLUserName(clnt_identity, identity);
 
     VIR_DEBUG("Authentication successful %d", virNetServerClientGetFD(client));
 
@@ -3148,6 +3153,7 @@ remoteSASLFinish(virNetServerPtr server,
           "client=%p auth=%d identity=%s",
           client, REMOTE_AUTH_SASL, identity);
 
+    virObjectUnref(clnt_identity);
     virObjectUnref(priv->sasl);
     priv->sasl = NULL;