]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commitdiff
target-i386: move carry computation for inc/dec closer to gen_op_set_cc_op
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 5 Oct 2012 22:18:55 +0000 (00:18 +0200)
committerRichard Henderson <rth@twiddle.net>
Mon, 18 Feb 2013 23:03:55 +0000 (15:03 -0800)
This ensures the invariant that cpu_cc_op matches s->cc_op when calling
the helpers.  The next patches need this because gen_compute_eflags and
gen_compute_eflags_c will take care of setting cpu_cc_op.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
target-i386/translate.c

index 48a3255a401f67bd6980270799a547b481e9a135..ed373c3ad6cfa35697abafd89cdc2eaacd7c270d 100644 (file)
@@ -1373,6 +1373,7 @@ static void gen_inc(DisasContext *s1, int ot, int d, int c)
         gen_op_ld_T0_A0(ot + s1->mem_index);
     if (s1->cc_op != CC_OP_DYNAMIC)
         gen_op_set_cc_op(s1->cc_op);
+    gen_compute_eflags_c(cpu_cc_src);
     if (c > 0) {
         tcg_gen_addi_tl(cpu_T[0], cpu_T[0], 1);
         s1->cc_op = CC_OP_INCB + ot;
@@ -1384,7 +1385,6 @@ static void gen_inc(DisasContext *s1, int ot, int d, int c)
         gen_op_mov_reg_T0(ot, d);
     else
         gen_op_st_T0_A0(ot + s1->mem_index);
-    gen_compute_eflags_c(cpu_cc_src);
     tcg_gen_mov_tl(cpu_cc_dst, cpu_T[0]);
 }