]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
plat/xen: Fix entry symbol for x86
authorSimon Kuenzer <simon@unikraft.io>
Tue, 17 Sep 2024 15:23:23 +0000 (17:23 +0200)
committerUnikraft Bot <monkey@unikraft.io>
Sat, 14 Dec 2024 10:47:46 +0000 (10:47 +0000)
When linking the final Xen image, most of the symbols are hidden except
for the entry symbol. By mistake, the x86_64 entry symbol was also hidden,
which caused the following linker warning:
 warning: cannot find entry symbol _libxenplat_start;
          defaulting to 00000000

This commit makes sure that `_libxenplat_start` is not masked out.

Signed-off-by: Simon Kuenzer <simon@unikraft.io>
Reviewed-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
Reviewed-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
Reviewed-by: Michalis Pappas <michalis@unikraft.io>
Approved-by: Michalis Pappas <michalis@unikraft.io>
GitHub-Closes: #1501

plat/xen/Linker.uk

index c90892e2f8330863de5a37a0e9c59b7462db5fc4..0c63547c562e3ba2514f0a505200acdf52609b40 100644 (file)
@@ -44,7 +44,7 @@ $(XEN_DEBUG_IMAGE): $(XEN_ALIBS) $(XEN_ALIBS-y) $(XEN_OLIBS) $(XEN_OLIBS-y) \
                        $(XEN_LDLIBS) $(XEN_LDLIBS-y) \
                        -o $(XEN_IMAGE).ld.o)
        $(call build_cmd,OBJCOPY,,$(XEN_IMAGE).o,\
-               $(OBJCOPY) -w -G xenos_* -G _libxenplat_zimageboot \
+               $(OBJCOPY) -w -G xenos_* -G _libxenplat_zimageboot -G _libxenplat_start \
                        $(XEN_IMAGE).ld.o $(XEN_IMAGE).o)
        $(call build_cmd,LD,,$@,\
               $(LD) $(LDFLAGS) $(LDFLAGS-y) $(XEN_LDFLAGS) $(XEN_LDFLAGS-y) \