]> xenbits.xensource.com Git - osstest.git/commitdiff
TestSupport: Avoid use of uninitialised $dtbs warning
authorIan Campbell <ian.campbell@citrix.com>
Fri, 24 Jul 2015 12:55:26 +0000 (13:55 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 28 Jul 2015 14:30:21 +0000 (15:30 +0100)
If $xopts{dtbs} wasn't set then neither was $dtbs.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Osstest/TestSupport.pm

index 7c1bb2c96718f2165483480da80ab0d0b8d33916..755a4ab4bb8b7075ead88c79b6dbc3007504496c 100644 (file)
@@ -2210,7 +2210,7 @@ sub setup_pxelinux_bootcfg ($$) {
 # Systems using BIOS are configured to use pxelinux
 sub setup_pxeboot_di_bios ($$$$$;%) {
     my ($ho,$kern,$initrd,$dicmd,$hocmd,%xopts) = @_;
-    my $dtbs = "fdtdir $xopts{dtbs}" if $xopts{dtbs};
+    my $dtbs = $xopts{dtbs} ? "fdtdir $xopts{dtbs}" : "";
     setup_pxelinux_bootcfg($ho, <<END);
     serial 0 $c{Baud}
 timeout 5