]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
hw/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in ppc_set_irq
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 18 Nov 2022 03:17:18 +0000 (19:17 -0800)
committerRichard Henderson <richard.henderson@linaro.org>
Thu, 5 Jan 2023 00:20:01 +0000 (16:20 -0800)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
hw/ppc/ppc.c

index dc86c1c7db856db7dbbc1275c957eeada6dc3204..4e816c68c759b2d8a4c52afc6018b822e13e4d37 100644 (file)
@@ -44,13 +44,9 @@ void ppc_set_irq(PowerPCCPU *cpu, int irq, int level)
 {
     CPUPPCState *env = &cpu->env;
     unsigned int old_pending;
-    bool locked = false;
 
     /* We may already have the BQL if coming from the reset path */
-    if (!qemu_mutex_iothread_locked()) {
-        locked = true;
-        qemu_mutex_lock_iothread();
-    }
+    QEMU_IOTHREAD_LOCK_GUARD();
 
     old_pending = env->pending_interrupts;
 
@@ -67,10 +63,6 @@ void ppc_set_irq(PowerPCCPU *cpu, int irq, int level)
 
     trace_ppc_irq_set_exit(env, irq, level, env->pending_interrupts,
                            CPU(cpu)->interrupt_request);
-
-    if (locked) {
-        qemu_mutex_unlock_iothread();
-    }
 }
 
 /* PowerPC 6xx / 7xx internal IRQ controller */