]> xenbits.xensource.com Git - libvirt.git/commitdiff
API: Init conn in case of it might be used uninitialized
authorOsier Yang <jyang@redhat.com>
Fri, 2 Sep 2011 04:49:24 +0000 (12:49 +0800)
committerOsier Yang <jyang@redhat.com>
Fri, 2 Sep 2011 07:41:29 +0000 (15:41 +0800)
There is a goto before "conn" is initialized.

src/libvirt.c

index 4284954e00cd6d8c50ad23073c739b2064b2213e..eca919ad0ea8c6fca9aa67b864f096d56b644ce1 100644 (file)
@@ -15225,12 +15225,13 @@ virDomainMigrateGetMaxSpeed(virDomainPtr domain,
         return -1;
     }
 
+    conn = domain->conn;
+
     if (!bandwidth) {
         virLibDomainError(VIR_ERR_INVALID_ARG, __FUNCTION__);
         goto error;
     }
 
-    conn = domain->conn;
     if (conn->flags & VIR_CONNECT_RO) {
         virLibDomainError(VIR_ERR_OPERATION_DENIED, __FUNCTION__);
         goto error;