]> xenbits.xensource.com Git - libvirt.git/commitdiff
rpc: avoid double close on error
authorEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 15:50:54 +0000 (09:50 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 17:43:36 +0000 (11:43 -0600)
Spotted by coverity.  If pipe2 fails, then we attempt to close
uninitialized fds, which may result in a double-close.

* src/rpc/virnetserver.c (virNetServerSignalSetup): Initialize fds.

src/rpc/virnetserver.c

index 2dae2ffa939fcbc4d29908aa3dfb0e138971938d..4deeca17dbcc1d9afebb9b258257bc89c586131e 100644 (file)
@@ -471,7 +471,7 @@ cleanup:
 
 static int virNetServerSignalSetup(virNetServerPtr srv)
 {
-    int fds[2];
+    int fds[2] = { -1, -1 };
 
     if (srv->sigwrite != -1)
         return 0;