]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
xenapi: Resolve Coverity FORWARD_NULL
authorJohn Ferlan <jferlan@redhat.com>
Tue, 10 Mar 2015 22:33:59 +0000 (18:33 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 11 Mar 2015 17:02:10 +0000 (13:02 -0400)
Since inception.  Coverity complains that the code checks "(record ==
NULL && !session->ok)", but doesn't check (record != NULL) before
dereferencing at "record->is_a_template"

src/xenapi/xenapi_driver.c

index afb6d6c8d81d92201834d4c1bfe1c975c3a7c135..821e9d94cec3cbd903e46e2a09c93341f763c660 100644 (file)
@@ -1646,9 +1646,11 @@ xenapiConnectNumOfDefinedDomains(virConnectPtr conn)
                 xen_vm_set_free(result);
                 return -1;
             }
-            if (record->is_a_template == 0)
-                DomNum++;
-            xen_vm_record_free(record);
+            if (record) {
+                if (record->is_a_template == 0)
+                    DomNum++;
+                xen_vm_record_free(record);
+            }
         }
         xen_vm_set_free(result);
         return DomNum;