]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: Use 'storage' layer nodename accessors in tests
authorPeter Krempa <pkrempa@redhat.com>
Mon, 25 Sep 2023 14:19:34 +0000 (16:19 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 17 Oct 2023 12:16:15 +0000 (14:16 +0200)
Convert all places in tests to use the 'storage' layer nodename
accessors instead of (virStorageSource)->nodestorage.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/qemublocktest.c
tests/qemumonitorjsontest.c
tests/qemuxml2argvtest.c

index edfe7719c8e1d546b1ad4d97f4fbea2b70540e84..9a72a67ce2365bcc17b1b59d4b136ef22941ccb2 100644 (file)
@@ -233,7 +233,7 @@ testQemuDiskXMLToJSONFakeSecrets(virStorageSource *src)
 
         srcpriv->secinfo->username = g_strdup(src->auth->username);
         srcpriv->secinfo->alias = g_strdup_printf("%s-secalias",
-                                                  NULLSTR(src->nodestorage));
+                                                  NULLSTR(qemuBlockStorageSourceGetStorageNodename(src)));
     }
 
     if (src->encryption) {
@@ -667,7 +667,7 @@ testQemuBackupIncrementalBitmapCalculateGetFakeImage(size_t idx)
    ret->type = VIR_STORAGE_TYPE_FILE;
    ret->format = VIR_STORAGE_FILE_QCOW2;
    ret->path = g_strdup_printf("/image%zu", idx);
-   ret->nodestorage = g_strdup_printf("libvirt-%zu-storage", idx);
+   qemuBlockStorageSourceSetStorageNodename(ret, g_strdup_printf("libvirt-%zu-storage", idx));
    ret->nodeformat = g_strdup_printf("libvirt-%zu-format", idx);
 
    return ret;
index 2e7b661db49bf3a1c8f8471f79ba1619e07dae9f..6b82e3841b469c602157e5c16ac416408f7a6a85 100644 (file)
@@ -2601,7 +2601,7 @@ testQemuMonitorJSONBlockdevReopen(const void *opaque)
     src->format = VIR_STORAGE_FILE_QCOW2;
     src->readonly = true;
     src->nodeformat = g_strdup("test node");
-    src->nodestorage = g_strdup("backing nodename");
+    qemuBlockStorageSourceSetStorageNodename(src, g_strdup("backing nodename"));
     src->backingStore = virStorageSourceNew();
 
     if (qemuMonitorTestAddItem(test, "blockdev-reopen", "{\"return\":{}}") < 0)
index a454dcb205769c34c429b6faa99696b326cce9d4..48058cb9241d5a9394f9bc76903970106f9e1f50 100644 (file)
@@ -12,6 +12,7 @@
 # include "internal.h"
 # include "viralloc.h"
 # include "viridentity.h"
+# include "qemu/qemu_block.h"
 # include "qemu/qemu_capabilities.h"
 # include "qemu/qemu_domain.h"
 # include "qemu/qemu_migration.h"
@@ -338,7 +339,7 @@ testCompareXMLToArgvCreateArgs(virQEMUDriver *drv,
 
                     srcpriv = qemuDomainStorageSourcePrivateFetch(src);
 
-                    srcpriv->fdpass = qemuFDPassNew(src->nodestorage, priv);
+                    srcpriv->fdpass = qemuFDPassNew(qemuBlockStorageSourceGetStorageNodename(src), priv);
                     qemuFDPassAddFD(srcpriv->fdpass, &fd, "-vdpa");
                 }
             }