]> xenbits.xensource.com Git - libvirt.git/commitdiff
umlConnectTapDevice: initialize tapfd variable
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 23 May 2013 13:22:35 +0000 (15:22 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 23 May 2013 13:22:35 +0000 (15:22 +0200)
There is possibility to jump to 'cleanup' label without tapfd variable
being initialized. In the label, VIR_FORCE_CLOSE(tapfd) is called which
can have fatal consequences.

src/uml/uml_conf.c

index a4088f2e6c3ffb364257b783274ef3ba5db83675..38dcfbb7dfd2a12ff1953c003c0aa99ac8cadb42 100644 (file)
@@ -109,7 +109,7 @@ umlConnectTapDevice(virConnectPtr conn,
                     const char *bridge)
 {
     bool template_ifname = false;
-    int tapfd;
+    int tapfd = -1;
 
     if (!net->ifname ||
         STRPREFIX(net->ifname, VIR_NET_GENERATED_PREFIX) ||