]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory
authorTim Wiederhake <twiederh@redhat.com>
Wed, 5 May 2021 10:55:47 +0000 (12:55 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 6 May 2021 10:16:32 +0000 (12:16 +0200)
Attributes are mandatory and were incorrectly made optional recently.

Fixes: 2a5e16398eb622f30dabb16770d2e14b7a6d5212
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 4a2c83b6f704c646c4cf9fe9f7ca1acfc0c8b0ee..58a46c5fa91f68edd6fa326de5ccc58aa7b1858f 100644 (file)
@@ -12739,12 +12739,12 @@ virDomainGraphicsDefParseXMLSpice(virDomainGraphicsDef *def,
 
         if (virXMLPropEnum(node_list[i], "name",
                            virDomainGraphicsSpiceChannelNameTypeFromString,
-                           VIR_XML_PROP_NONE, &name) < 0)
+                           VIR_XML_PROP_REQUIRED, &name) < 0)
             return -1;
 
         if (virXMLPropEnum(node_list[i], "mode",
                            virDomainGraphicsSpiceChannelModeTypeFromString,
-                           VIR_XML_PROP_NONE, &mode) < 0)
+                           VIR_XML_PROP_REQUIRED, &mode) < 0)
             return -1;
 
         def->data.spice.channels[name] = mode;