]> xenbits.xensource.com Git - libvirt.git/commitdiff
zfs: Resolve RESOURCE_LEAK
authorJohn Ferlan <jferlan@redhat.com>
Fri, 19 Feb 2016 18:54:45 +0000 (13:54 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 25 Feb 2016 16:52:49 +0000 (11:52 -0500)
Found by my Coverity checker - virCheckFlags call could return -1, but
not virCommandFree(destroy_cmd).

Signed-off-by: John Ferlan <jferlan@redhat.com>
src/storage/storage_backend_zfs.c

index 6bf79634e17448fa9b4bc0f62d0b251ccef48cae..4d04c703546a1d20bc491cbc3689fe0be6f20b28 100644 (file)
@@ -355,10 +355,12 @@ virStorageBackendZFSDeleteVol(virConnectPtr conn ATTRIBUTE_UNUSED,
                               unsigned int flags)
 {
     int ret = -1;
-    virCommandPtr destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
+    virCommandPtr destroy_cmd = NULL;
 
     virCheckFlags(0, -1);
 
+    destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
+
     virCommandAddArgFormat(destroy_cmd, "%s/%s",
                            pool->def->source.name, vol->name);