]> xenbits.xensource.com Git - xen.git/commitdiff
libxl/ACPI: don't hard-code guest page size
authorJan Beulich <jbeulich@suse.com>
Tue, 26 Nov 2024 10:24:56 +0000 (11:24 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 26 Nov 2024 10:24:56 +0000 (11:24 +0100)
We have libxl_ctxt.page_size for this purpose; use it to eliminate a
latent buffer overrun.

Fixes: 14c0d328da2b ("libxl/acpi: Build ACPI tables for HVMlite guests")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
tools/libs/light/libxl_x86_acpi.c

index 2574ce25531812d1385e6036baafc0837655bcc0..378524aeef52303bc23e7f9903e1c109521ef94f 100644 (file)
@@ -218,7 +218,7 @@ int libxl__dom_load_acpi(libxl__gc *gc,
         dom->acpi_modules[0].guest_addr_out = 0x100000 - 64;
 
     dom->acpi_modules[1].data = (void *)config.infop;
-    dom->acpi_modules[1].length = 4096;
+    dom->acpi_modules[1].length = libxl_ctxt.page_size;
     dom->acpi_modules[1].guest_addr_out = ACPI_INFO_PHYSICAL_ADDRESS;
 
     dom->acpi_modules[2].data = libxl_ctxt.buf;