]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
x86: restore semicolon after explicit DS prefix
authorJan Beulich <jbeulich@suse.com>
Thu, 10 Oct 2024 08:54:15 +0000 (10:54 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 10 Oct 2024 08:54:15 +0000 (10:54 +0200)
It's not unnecessary (as the earlier commit claimed): The integrated
assembler of Clang up to 11 complains about an "invalid operand for
instruction".

Fixes: b42cf31d1165 ("x86: use alternative_input() in cache_flush()")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/flushtlb.c

index 2a70c5151bb2424634dff7ebd5d920e18535c4e6..65be0474a8ead655736d8ba1406fe5aeb3882f51 100644 (file)
@@ -286,7 +286,7 @@ void cache_flush(const void *addr, unsigned int size)
          * + prefix than a clflush + nop, and hence the prefix is added instead
          * of letting the alternative framework fill the gap by appending nops.
          */
-        alternative_input("ds clflush %[p]",
+        alternative_input("ds; clflush %[p]",/* Semicolon for Clang-IAS < 12 */
                           "data16 clflush %[p]", /* clflushopt */
                            X86_FEATURE_CLFLUSHOPT,
                            [p] "m" (*(const char *)(addr)));