]> xenbits.xensource.com Git - people/aperard/qemu-dm.git/commitdiff
tests/qtest: check the return value
authorZhu Jun <zhujun2@cmss.chinamobile.com>
Tue, 21 Nov 2023 08:08:02 +0000 (00:08 -0800)
committerThomas Huth <thuth@redhat.com>
Mon, 4 Dec 2023 14:12:57 +0000 (15:12 +0100)
These variables "ret" are never referenced in the code, thus
add check logic for the "ret"

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231121080802.4500-1-zhujun2@cmss.chinamobile.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/test-filter-mirror.c
tests/qtest/test-filter-redirector.c
tests/qtest/virtio-net-test.c

index adeada3eb87db417f7ee8e4db7c072fe1bea02df..f3865f75196e70e86b737c58c43ebfb22d031f82 100644 (file)
@@ -61,6 +61,7 @@ static void test_mirror(void)
     g_assert_cmpint(len, ==, sizeof(send_buf));
     recv_buf = g_malloc(len);
     ret = recv(recv_sock[0], recv_buf, len, 0);
+    g_assert_cmpint(ret, ==, len);
     g_assert_cmpstr(recv_buf, ==, send_buf);
 
     g_free(recv_buf);
index e72e3b787359c6a3ad2cb9b24f77ad1c8dc730aa..a77d5fd8ec0982674c0298824c34b5fea54c98ea 100644 (file)
@@ -118,6 +118,7 @@ static void test_redirector_tx(void)
     g_assert_cmpint(len, ==, sizeof(send_buf));
     recv_buf = g_malloc(len);
     ret = recv(recv_sock, recv_buf, len, 0);
+    g_assert_cmpint(ret, ==, len);
     g_assert_cmpstr(recv_buf, ==, send_buf);
 
     g_free(recv_buf);
@@ -185,6 +186,7 @@ static void test_redirector_rx(void)
     g_assert_cmpint(len, ==, sizeof(send_buf));
     recv_buf = g_malloc(len);
     ret = recv(backend_sock[0], recv_buf, len, 0);
+    g_assert_cmpint(ret, ==, len);
     g_assert_cmpstr(recv_buf, ==, send_buf);
 
     close(send_sock);
index fab5dd8b0583b89d0fecd883c1c9b6f94f7b5558..2df75c9780ce13d6a0051700e8d8209678e87760 100644 (file)
@@ -91,6 +91,7 @@ static void tx_test(QVirtioDevice *dev,
     len = ntohl(len);
 
     ret = recv(socket, buffer, len, 0);
+    g_assert_cmpint(ret, ==, len);
     g_assert_cmpstr(buffer, ==, "TEST");
 }