]> xenbits.xensource.com Git - libvirt.git/commitdiff
storage_backend_rbd: Correct argument order to rbd_create3
authorSteven McDonald <steven.mcdonald@anchor.net.au>
Tue, 29 Apr 2014 02:19:01 +0000 (12:19 +1000)
committerEric Blake <eblake@redhat.com>
Tue, 29 Apr 2014 04:11:09 +0000 (22:11 -0600)
The stripe_unit and stripe_count arguments are passed to rbd_create3 in
the wrong order, resulting in a stripe size of 1 byte with 4194304
stripes on newly created RBD volumes.

https://bugzilla.redhat.com/show_bug.cgi?id=1092208
Signed-off-by: Steven McDonald <steven.mcdonald@anchor.net.au>
src/storage/storage_backend_rbd.c

index 029d2f0f3cbd30adbd06327df7a681d5c49d6dd4..5d4ef7900f5c85f09b94ac2d8697aceb11f41d23 100644 (file)
@@ -492,7 +492,7 @@ static int virStorageBackendRBDCreateImage(rados_ioctx_t io,
     uint64_t stripe_unit = 4194304;
 
     if (rbd_create3(io, name, capacity, features, &order,
-                    stripe_count, stripe_unit) < 0) {
+                    stripe_unit, stripe_count) < 0) {
 #else
     if (rbd_create(io, name, capacity, &order) < 0) {
 #endif